[TheOutcaste]

Would be nice if it was that easy, but it only works with For variables or the batch parameters %0-%9. A For statement is probably easiest, but you can also use call:

set _filename=c:\test1\file.txt
call :_getfnext %_filename%
call :_getpath %_filename%
echo.Filename and extension is %_fn%
echo.Path to %_fn% is %_pn%
set var=C:\ABC\DEF\something.pdf
call :_getfnext %var%
echo.Filename and extension is now %_fn%
goto:eof
:_getfnext
set _fn=%~nx1
goto:eof
:_getpath
set _pn=%~dp1
goto:EOF

A little bug is you don't need the surrounding % symbols to get the path name; call :_getpn _filename works the same as call :_getpn %_filename%

I haven't tried all the modifiers to see which ones will work that way, but best use the % symbols properly in case other versions of cmd don't have that bug.

EDIT: Just to avoid confusion I've highlighted the batch variable number in red -- those are the number one, not a lower case "L"

[devil_himself]

you can do it this way

@echo off
set var=%1
set new_var=%~dp1
echo %new_var%

edit - i'm a slow typer

[Squashman]

You both sure are schooling me on batch files. Thanks for all the help.

[Squashman]

Originally Posted by devil_himself

if you want the output to be like this

"Name"         :"Address"      :"City"         :"State"        :"ZipCode"      :"Filename"      
"John Doe"     :"503 Grand Ave":"San Jose"     :"CA"           :"93456"        :"file1.txt"     
"Jim Andersen" :"512 Grand Ave":"San Diego"    :"WA"           :"93456"        :"file2.txt"

then this should do it

@echo off & setlocal enableextensions enabledelayedexpansion
  for /f "tokens=1-6 delims=:" %%a in ('type Myfile.txt') do (
   set l1=%%a               .
   set l2=%%b               .
   set l3=%%c               .
   set l4=%%d               .
   set l5=%%e               .
   set l6=%%f               .
   echo !l1:~0,15!:!l2:~0,15!:!l3:~0,15!:!l4:~0,15!:!l5:~0,15!:!l6:~0,15! >>newfile.txt
   )
  endlocal & goto :EOF

As I was saying earlier, I think I could use this example with a different order I work on. Again, I want to append the filename to the end of each line but this file is already in a fixed format. The filenames are anywhere from 5 to 8 positions long. But I want to maintain the same line length for all records. So I am think I could integrate your example above with my current batch file. I am thinking I would just expand it out to 10 positions. Just add the appropriate amount of blanks to the end. I kind of see that your set statement adds 16 positions to the variable. Then I assume that echo statement outputs the first 15 positions of the variable. I am thinking I might be able to put that into my SED statement to do the replace. Not sure. Will have to test.

[Squashman]

found this neat little utility called Swiss File Knife.

Has a nice option called addtail. Works like a charm.

FOR /F "tokens=1* delims=." %%A IN ('dir /b /a-d *.TXT') DO echo "Working on file: %%A" && type "%%A.TXT" | sfk addtail %%A >> FILES_COMBINED.txt




.

[Squashman]

Not quite sure why this isn't working the way I want it to. It doesn't seem to add the spaces to the end of the filename. It only adds the filename. My filenames are 6 to 8 characters long but I want to make the filenames 10 characters so I add some spaces. The reason I am doing that is so the line lengths are the same for all lines on the output.

:: Append the Filename to the end of each line of every file and combine all files together
FOR /F "tokens=1* delims=." %%A IN ('dir /b /a-d *.TXT') DO (
     set _Tfile=%%A               .
     set _Filename=!_Tfile:~0,10!
     echo "Working on file: %%A"
     type "%%A.TXT"|sfk addtail !_Filename! >> FILES_COMBINED.tmp
     )

[Squashman]

Ignore the stupid person posting. Why do I always forget quotes. Devil, Thanks alot for that tip on substrings.

[TheOutcaste]

Just a suggestion:
With the FOR /F "tokens=1* delims=." you can't use names with a period. Example, my.file.txt will end up with _Filename being "my " (my followed by 8 spaces) and the type statement will be type my.txt which may not exist, and the File not found error may go unnoticed. Worse, it may actually exist, so it will get processed twice while my.file.txt gets skipped. You may not be using filenames with that format now, but who knows what someone will try 6 months from now.

The following will get the complete filename into the %%A variable, then uses %%~nA to specify the name portion only, so names with a period will be preserved. I haven't had a chance to download and play with sfk, so I'm guessing the missing quotes should be around !_Filename!.
Looks like a very useful tool. Thanks for finding that!

:: Append the Filename to the end of each line of every file and combine all files together
FOR /F "tokens=*" %%A IN ('dir /b /a-d *.TXT') DO (
     set _Tfile=%%~nA               .
     set _Filename=!_Tfile:~0,10!
     echo "Working on file: %%~nA"
     type "%%A"|sfk addtail "!_Filename!" >> FILES_COMBINED.tmp
     )

HTH

Jerry

[Squashman]

I like how you think. That should make it just about foolproof.

Still wondering if I could do my file counts differently. Would be nice if I could count the records as I am processing the files, instead of counting them before and after. But I think if I do that I will start running into memory issues like we did with the profanity batch. I just do that to verify my input and output file counts.

Wasn't sure if I could put something in there that would increment a counter for each filename as it is processed. I assume this wouldn't work because I am echoing(typing) the file to another command and then redirecting output. I assume I couldn't put a counter in there because it would increment the counter until it was done typing the file. I thought maybe I could use the filename variable as part of the counter variable and then echo that variable to my Log file at the end of the batch in another loop. This would only work I assume if the loop was parsing one line of the file at a time. Instead the loop is controlled by the filename being processed.
set /a !_Filename!_count+=1

I suppose I could create another For Loop inside the first For Loop that types the file but again if it tries to load the entire file into memory, I think that it will choke on memory again.

FOR /F "tokens=*" %%A IN ('dir /b /a-d *.TXT') DO (
     set _Tfile=%%~nA               .
     set _Filename=!_Tfile:~0,10!
     echo "Working on file: %%~nA"
     FOR /F %%B IN ('type %%A') DO (
     set /a !_Filename!_count+=1
     echo.%%B|sfk addtail "!_Filename!" >> FILES_COMBINED.tmp
     )
     echo.!_Filename!_count >>Appendlog.log
     )

Not even sure if that will work. I am at home right now. Would have to test it on a large file later on went I get to work tonight.

[TheOutcaste]

There ya go forgetting those quotes again. Also, need to specify the "tokens=*" or remove delimiters with "delimns=", or any line containing a space or tab will be truncated.

FOR /F "tokens=*" %%B IN ('type "%%A"') DO (

Not sure about the memory issue. Testing will tell. The extra FOR loop will likely slow it down quite a bit though.

Find can be used to count lines, but its not real fast. Didn't time it counting my file with 28,799,994 records (about 80 bytes each), but seems like about 10-20 minutes. Had two counts running, and the PC was recording TV at the same time though. I just typed the commands; should have run a batch and logged the times.
Find was faster than findstr though, and didn't hang like findstr did when it finished.
You might try starting a separate batch file to do the count, and let it run in another process. Haven't tested this, might have to use start so that it doesn't wait for it to finish, but that would open another command prompt window.

 FOR /F "tokens=*" %%A IN ('dir /b /a-d *.TXT') DO (cmd /c count.bat %%A  
     set _Tfile=%%~nA               .
     set _Filename=!_Tfile:~0,10!
     echo "Working on file: %%~nA"
     FOR /F %%B IN ('type %%A') DO (
     set /a !_Filename!_count+=1
     echo.%%B|sfk addtail "!_Filename!" >> FILES_COMBINED.tmp
     )
     echo.!_Filename!_count >>Appendlog.log
     )

count.bat would contain:

>>appendlog.log find /v /c "@@this#won't#be#found@@" %1

Or whatever method you are using to count records. Find outputs the file name, if your counting some other way just add

>>appendlog.log echo.File %1 count is:

to the start of count.bat

Jerry