[Squashman]

My next order of busines is to do a profanity search. I have a file with a list of profanity words in it. One word per line. Need to search a data file and output the lines that match any of the profanity words in my Profanity file to one file and the ones that don't match to another file. I think I could do that with a For, Type,echo and Findstr commands. Get the errorlevel of findstr and echo the line to the appropriate output file. Something like

for /f %%a in (type somefile.txt) do echo %%a | findstr /grofanitywords.txt | if errorlevel==0 echo %%a >> profanity_output.txt else echo %%a>>not_profanity.txt

Something like that. I know the syntax isn't correct. Just trying to convey what I am thinking in a more technical manner.

[TheOutcaste]

Try this:

@echo off
Set _WL=Profanitywords.txt
Set _OF1=profanity_output.txt
Set _OF2=Not_Profanity.txt
Set _SF=file 1.txt
If EXIST %_OF1% del %_OF1%
If EXIST %_OF2% del %_OF2%
For /f "usebackq tokens=*" %%a In ("%_SF%") Do (
   echo.%%a|findstr /g:"%_WL%">>%_OF1%
   echo.%%a|findstr /v /g:"%_WL%">>%_OF2%)
For %%A In (WL OF1 OF2 SF) Do Set _%%A=

Jerry

[TheOutcaste]

This one is much faster, as it only does the findstr once per line

@echo off
Echo.%time%>time1.txt
setlocal enabledelayedexpansion
Set _WL=search.txt
Set _OF0=Profanity.txt
Set _OF1=Not_Profanity.txt
Set _SF=file 1.txt
If EXIST %_OF0% del %_OF0%
If EXIST %_OF1% del %_OF1%
For /f "usebackq tokens=*" %%a In ("%_SF%") Do (
  Set _T0=%%a & echo.%%a|findstr /g:"%_WL%">nul & call :_Output!errorlevel!
  )
Echo.%time%>>time1.txt
Goto:EOF
:_Output0
echo.!_T0!>>%_OF0%
Goto:EOF
:_Output1
echo.!_T0!>>%_OF1%
Goto:EOF

But your original idea using if then else is the fastest:

@echo off
setlocal enabledelayedexpansion
Set _WL=search.txt
Set _OF0=Profanity.txt
Set _OF1=Not_Profanity.txt
Set _SF=file 1.txt
If EXIST %_OF0% del %_OF0%
If EXIST %_OF1% del %_OF1%
For /f "usebackq tokens=*" %%a In ("%_SF%") Do (
  echo.%%a|findstr /g:"%_WL%">nul
  If !errorlevel!==0 (echo.%%a>>%_OF0%) else echo.%%a>>%_OF1%
  )

On a relative scale, times for the 1st, 2nd, and 3rd versions are:

1. 1.000
2. 0.556
3. 0.500

Not too surprising that the first one takes twice as long, as it does the findstr twice.
Doesn't seem to make any difference if you use the /v switch on findstr.

Jerry

[Squashman]

I am think I should probably throw in a /I so it is not case sensitive.

[Squashman]

And I forgot to say Thanks again!!!!

[TheOutcaste]

Originally Posted by Squashman

I am think I should probably throw in a /I so it is not case sensitive.

Good catch! Seems I did forget to do that.

And You're Welcome!

BTW, I did finally convert the other batch to an exe; didn't make a noticeable difference in speed, still 35 minutes. It was a freeware converter - a paid version might make a difference, but probably won't come close to beating the *nix utilities.

[Squashman]

I found a really nice bat2exe that is free. I took the batch file I wrote and it let me compile it with all my ported unix utilities. Glad you mentioned that. Makes things much easier.

Now, I justed need to see how long it will take to run your profanity suppression on something like 1 million lines.

[devil_himself]

you can also do it like this

for /f %%a in (myfile.txt) do (find /i  "%%a" "Profanitywords.txt">nul)&& echo %%a>>pr.txt || echo %%a>>npr.txt

[Squashman]

Originally Posted by devil_himself

you can also do it like this

for /f %%a in (myfile.txt) do (find /i  "%%a" "Profanitywords.txt">nul)&& echo %%a>>pr.txt || echo %%a>>npr.txt

Thanks, I will test that out when I get back to work. Need to mock up a file with a couple million records to see what happens.

[Squashman]

Trying to use the ConGetFile Utility to prompt me for a filename. Can't get it to work.

@echo off
setlocal enabledelayedexpansion
Set _WL=search.txt
Set _OF0=Profanity.txt
Set _OF1=Not_Profanity.txt
If EXIST %_OF0% del %_OF0%
If EXIST %_OF1% del %_OF1%
For /f "usebackq tokens=*" %%a In ('ConGetFile') Do (
  set InFile=%%a
  echo.%InFile%|findstr /I /g:"%_WL%">nul
  If !errorlevel!==0 (echo.%%a>>%_OF0%) else echo.%%a>>%_OF1%
  )

[devil_himself]

@for /f "tokens=*" %%a in ('ConGetFile') do set file=%%a

[devil_himself]

oops .. in full code

@echo off
setlocal enabledelayedexpansion
Set _WL=search.txt
Set _OF0=Profanity.txt
Set _OF1=Not_Profanity.txt
If EXIST %_OF0% del %_OF0%
If EXIST %_OF1% del %_OF1%
for /f "tokens=*" %%a in ('ConGetFile') do (
  for /f "usebackq tokens=*" %%b in ("%%a") do (  
  echo.%%b|findstr /I /g:"%_WL%">nul
  If !errorlevel!==0 (echo.%%b>>%_OF0%) else echo.%%b>>%_OF1%
 )
)

[Squashman]

Nevermind. I got it.

@echo off
setlocal enabledelayedexpansion
Set _WL=search.txt
Set _OF0=Profanity.txt
Set _OF1=Not_Profanity.txt
If EXIST %_OF0% del %_OF0%
If EXIST %_OF1% del %_OF1%
FOR /F "tokens=*" %%A in ('ConGetFile.exe') Do Set _Input=%%A
For /f "usebackq tokens=*" %%a In ("%_Input%") Do (
  echo.%InFile%|findstr /I /g:"%_WL%">nul
  If !errorlevel!==0 (echo.%%a>>%_OF0%) else echo.%%a>>%_OF1%
  )

[TheOutcaste]

You've already figured it out, but just to clarify, when using the usebackq option you have to use an Accent Grave (` {usually under tilde ~}) around the command instead of the Apostrophe/Single Quote (')
So, instead of this:
For /f "usebackq tokens=*" %%a In ('ConGetFile') Do
you have to use this:
For /f "usebackq tokens=*" %%a In (`ConGetFile`) Do

But the only time you need to use the usebackq option is if the IN part of the For command contains a file name with quotes.
Some examples:

• For /f "tokens=*" %a In (copy of search.txt) Do @echo Variable=%a
  Gives an error:
  The system cannot find the file copy.
• If you use quotes around the file name
  For /f "tokens=*" %a In ("copy of search.txt") Do @echo Variable=%a
  the output is:
  Variable=copy of search.txt
• if you use this:
  For /f "usebackq tokens=*" %a In ("copy of search.txt") Do @echo Variable=%a
  The output will be the contents of the file "copy of search.txt"
  Variable=This is line one
  Variable=This is line two

Jerry

[Squashman]

Thanks again for all the great input!