[Daz224]

Hi there, I'm coding a card game and running into problems. I wrote a function that will check a user's hand for pairs and report back if there are any. Trouble is, it's misreporting most of the time.

Private Sub CheckPairs()

Dim i As Integer, j As Integer, booPairs As Boolean

booPairs = False

    For i = 0 To 11
        For j = i + 1 To 11
            If (intHand(0, j) Mod 13) = (intHand(0, i) Mod 13) Then booPairs = True
                If intHand(0, j) = 99 And intHand(0, i) = 99 Then booPairs = False: Exit For
        Next j
    Next i

    If booPairs = True Then lblMessage.Caption = "You still have pairs!" Else lblMessage.Caption = "Right let's go"

End Sub

[aewarnick]

To optimize your code I would make the second If an else if (else if is C++).
What is intHand?

[Daz224]

inthand is the variable that holds the card values. (0) is Player 1's hand.

[jiml8]

When you say it "misreports", I'll bet it is double-counting the pairs, isn't it.

You are searching the same dimension of one array using two indices, and you are looping both indices over the entire array. So everything will be picked up twice.