[CodeNoob]

4 function calculator, add subtract multipy divide please help
i cannot get it to loop
here is my code please help:
#include <iostream>
using namespace std;
void showmenu();
float math();
float first,second;
float ans;

char op;
int main()
{
cout<< "Calculator\n ";
showmenu();

cin>>op;

while(op!='!')

{

cout<< "Please Enter The First Number\n";
cin>>first;
cout<< "\nEnter a Second Number\n";
cin>>second;
cout<<first
<<op
<<second
<<"=";
ans=math();

cin.get();

cin.get();
return 0;
}
}
void showmenu()
{
cout<<"Operations are as follows...\n"
<<"'*' Multiplication\n"
<<"'/' Division\n"
<<"'-' Subtraction\n"
<<"'+' Addition\n"
<<"Press '!' to exit\n"
<<"Please Enter An Operation\n";
}

float math()
{
float result;

if (op == '+') {
result=first+second;
cout<< result;
} else if (op == '-') {
result=first-second;
cout<< result;
} else if (op == '*') {
result=first*second;
cout<< result;
} else if (op == '/') {
if ((first == 0)&&(second==0)) {
cout << "Error: Divide by zero\n";
cout << " operation ignored\n";
} else
result=first/second;
cout<< result;
return result;

}
}

[dquigley]

Hi welcome to TSG!

The primary problem is where you are placing the return 0 in the main() function. You have it placed inside the while { } statement. So the program will always exit without looping.

Good job on how you catch the divide by zero condition... you may want to consider using a switch statement instead of the if and else conditionals. Here is a code snippet that may get you thinking about making your code a bit more bullet proof, it uses another loop type and could be useful to you.

void menu()
{
    bool valid;
    do
    {
        cout<<"\nOperations are as follows...\n"
        <<"'*' Multiplication\n"
        <<"'/' Division\n"
        <<"'-' Subtraction\n"
        <<"'+' Addition\n"
        <<"Press '!' to exit\n"
        <<"Please Enter An Operation:";
        
        cin >> op;

        cout << "\n";

        switch (op)
        {
            case '*':
            case '/':
            case '-':
            case '+':
            case '!':
                {
                    valid = true;
                    break;
                }
            default:
                {
                valid = false;
                cout << "\nInvalid Operation!\n";
                }
        }
    } 
    while (!valid);
}

Keep at it.

Best,
Dan