[CodeNoob]

im trying to make a full deck of cards and i pretty much got it exept im trying to get it to output the suit as a symbol like ♣,♠,♥,♦ and it wont work my code is as follows:
/*"fulldeck"
programing by
John Wright*/

#include <iostream>


using namespace std;

struct card
{
char name;
int suit,value;
bool drawn;
};

int main()
{ card deck[53] ;
int i=0;
while (i<=39) // Makes Deck
{
deck[0+i].name='a'; //Type Of Card
deck[1+i].name='2';
deck[2+i].name='3';
deck[3+i].name='4';
deck[4+i].name='5';
deck[5+i].name='6';
deck[6+i].name='7';
deck[7+i].name='8';
deck[8+i].name='9';
deck[9+i].name='t';
deck[10+i].name='j';
deck[11+i].name='q';
deck[12+i].name='k';

deck[0+i].value=1; // Value Of Card
deck[1+i].value=2;
deck[2+i].value=3;
deck[3+i].value=4;
deck[4+i].value=5;
deck[5+i].value=6;
deck[6+i].value=7;
deck[7+i].value=8;
deck[8+i].value=9;
deck[9+i].value=10;
deck[10+i].value=11;
deck[11+i].value=12;
deck[12+i].value=13;

deck[i].suit=((i/13)+2); //Suit Of Card

deck[i].drawn=0; // The Number Of Cards Drawn or Not
i+=13;
}
i=0;

//Outputs Deck

i=0;
while (i<=51)
{
cout<< deck[i].name<<char(deck[i].suit)<<endl;
i++;
}





cin.get();
cin.get();
return 0;
}
problem is underlined please help!

[dquigley]

You're not initializing the deck properly and only setting four out of the 52 with a suit. Here is one way to solve it.

#include <iostream>
using namespace std;

#define CARDS 52
#define SUITS 4
#define CARDS_IN_SUIT (CARDS/SUITS)

struct card
{
	char name;
	char suit;
	int value;
	bool drawn;
};

int main()
{

	card deck[CARDS] ;
	int i = 0;
	for(int s=0; s<SUITS; s++)
	{
		for(int c=0; c<CARDS_IN_SUIT; c++)
		{
			switch (c + 1)
			{
			case 1:
				deck[i].name = 'a';
				break;
			case 10:
				deck[i].name = 't';
				break;
			case 11:
				deck[i].name = 'j';
				break;
			case 12:
				deck[i].name = 'q';
				break;
			case 13:
				deck[i].name = 'k';
				break;
			default:
				deck[i].name = (char)c + '1';
				break;
			}
			deck[i].suit = (char)(s + 3);
			deck[i].value = c + 1;
			deck[i].drawn = false;
			i++;
		}
	}

	//Outputs Deck

	i=0;
	while (i<CARDS) 
	{ 
		cout<< deck[i].name<<char(deck[i].suit)<<endl;
		i++; 
	}

	cin.get();
	cin.get();
	return 0;
}

[blaqDeaph]

Personally I'd prefer to solve this without so much clutter and switching functions. Just initialize an array of characters, like this:

char cname[] = "a23456789tjqk", then you can simply use:

deck[i].name = cname[c % 13];

rather than a bunch of switch statements. I thought it looks better (it may be slightly faster, but thats probably not noticable, unless you're initializing 1million decks. But both work.

[dquigley]

Agreed... I was trying to introduce him to more of the language

Best,
Dan

[CodeNoob]

Thank You Very Much i appreciate the help really!!!