There's no such thing as a stupid question, but they're the easiest to answer.
JoinTour
Login
 
Tag Cloud
access audio avg avg 8 bios blue screen boot bsod computer connection cpu crash css dell desktop dma driver drivers dvd email error excel explorer firefox firefox 3 freeze gimp graphics hard drive hardware hijackthis hjt install internet internet explorer itunes keyboard laptop macro malware monitor motherboard network networking outlook outlook 2003 outlook 2007 outlook express pio problem problems router seo server slow sound sp3 spyware trojan usb video virtumonde virus vista vundo windows windows vista windows xp winxp wireless
Software Development
Search
Search in:
 
Advanced Search
Tech Support Guy Forums > Software & Hardware > Software Development >
Batch File: For Loop Help!!!!!!!!!!


HELLO AND WELCOME! Before you can post your question, you'll have to register -- it's completely free! Click here to join today! We highly recommend that you print a copy of our Guide for New Members. Enjoy!

 
Thread Tools
closerwalk's Avatar
Computer Specs
Junior Member with 2 posts.
 
Join Date: Mar 2008
Experience: Advanced
20-Mar-2008, 04:47 PM #1
Batch File: For Loop Help!!!!!!!!!!
Here we go:
I have the following batch file:

Code:
ipconfig | find "IP Address. . . . . . . . . . . . : 10" > ip1.txt

for /f "tokens=1-2 delims=:" %i in (ip1.txt) do echo %%j >ip2.txt
for /f "tokens=1-4 delims=." %i in (ip2.txt) do set IPADDR= %i.%j.%k.%l

echo %username%, %computername%, %date%,%time%,%IPADDR%,LOGGED ON>>\\servername\data\audit\LOGON_LOGOFF_EVENTS.txt
On a windows xp machine this works fine if you past it into a command prompt.

You can test it by just pasting into a command prompt or cmd prompt:
You will see that it works as advertised ...
Code:
ipconfig | find "IP Address. . . . . . . . . . . . : 10" > ip1.txt

for /f "tokens=1-2 delims=:" %i in (ip1.txt) do echo %%j >ip2.txt
for /f "tokens=1-4 delims=." %i in (ip2.txt) do set IPADDR= %i.%j.%k.%l

echo %username%, %computername%, %date%,%time%,%IPADDR%,LOGGED ON



Heres the But: If I run it using the batch file it produces this error:


C:\>ipconfig | find "IP Address. . . . . . . . . . . . : 10" 1>ip1.txt
j was unexpected at this time.
C:\>for /f "tokens=1-2 delims=:" j >ip2.txt)

Any suggestions ???
devil_himself's Avatar
Distinguished Member with 4,817 posts.
 
Join Date: Apr 2007
Location: India
Experience: Advanced
20-Mar-2008, 09:05 PM #2
Greetings closerwalk , Welcome To TSG

Inside A Batch Script Two "%'s" in %%f, are required .The first % escapes the second %, so that the for command to actually work. On the command line itself, you only use one %.

Code:
@echo off
ipconfig | find "IP Address. . . . . . . . . . . . : 10" > ip1.txt

for /f "tokens=1-2 delims=:" %%i in (ip1.txt) do echo %%j >ip2.txt
for /f "tokens=1-4 delims=." %%i in (ip2.txt) do set IPADDR= %%i.%%j.%%k.%%l

echo %username%, %computername%, %date%,%time%,%IPADDR%,LOGGED ON
closerwalk's Avatar
Computer Specs
Junior Member with 2 posts.
 
Join Date: Mar 2008
Experience: Advanced
21-Mar-2008, 05:09 PM #3
Thanks, I total overlooked that...
devil_himself's Avatar
Distinguished Member with 4,817 posts.
 
Join Date: Apr 2007
Location: India
Experience: Advanced
21-Mar-2008, 09:31 PM #4
Glad We Could Help

You Can Use The "Thread Tools" At The Top To Mark The "Thread" As "Solved"

Reply


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are Off
Refbacks are Off

You Are Using:
Server ID
Advertisements do not imply our endorsement of that product or service.
All times are GMT -4. The time now is 02:36 PM.
Copyright © 1996 - 2008 TechGuy, Inc. All rights reserved.
Powered by vBulletin, Copyright © 2000 - 2008, Jelsoft Enterprises Ltd.
Search Engine Optimization by vBSEO 3.1.0
Powered by Cermak Technologies, Inc.