[Grob needs help]

i am working on a project to create a simple browser based MMORPG and i am currently trying to create the battle script but i have encountered a problem with updating the mysql table with the users involed in the script, the code i am using is

the $_post data is coming from another page where the opponents are selected

mysql_query("UPDATE fight SET attacked = '$_POST[opponent]' AND attacking = '$_POST[attacker]' WHERE name = '$_POST[opponent]'");
mysql_query("UPDATE fight SET attacked = '$_POST[opponent]' AND attacking = '$_POST[attacker]' WHERE name = '$_POST[attacker]' ");

the problem is it does not update the table at all can anyone help me, i am sure there must be a simple answer

thanks

[ehymel]

use some error checking so you can get some clues about what is going wrong:

mysql_query($query) or die("ERROR: ".mysql_error());

I would also suggest that your code is lacking terribly in some basics checks. In this case, I think you'll see that your sql command is wrong, in turn becase your $_POST syntax is wrong.

A much more robust set of commands would look something like this:
mysql_query("UPDATE fight SET attacked = '$_POST[opponent]' AND attacking = '$_POST[attacker]' WHERE name = '$_POST[opponent]'");
mysql_query("UPDATE fight SET attacked = '$_POST[opponent]' AND attacking = '$_POST[attacker]' WHERE name = '$_POST[attacker]' ");

$opponent = $_POST['opponent'];
$attacker = $_POST['attacker'];

if (( strlen($opponent) > 0 ) && ( strlen($attacker) > 0 )) {
  $sql = "UPDATE flight SET attacked = '$opponent' AND attacking = '$attacker' WHERE name = '$opponent'";
  $result = mysql_query($query) or die("<b>A fatal MySQL error occured</b>.\n<br />Query: " . $sql . "<br />\nError: (" . mysql_errno() . ") " . mysql_error());

  $sql = "UPDATE flight SET attacked = '$opponent' AND attacking = '$attacker' WHERE name = '$attacker'";
  $result = mysql_query($query) or die("<b>A fatal MySQL error occured</b>.\n<br />Query: " . $sql . "<br />\nError: (" . mysql_errno() . ") " . mysql_error());

} else {
  die("Missing opponent or attacker information; opponent='$opponent' and attacker='$attacker'");
}

I typed this free-hand, so there may be spelling errors, but the point is that you should be doing some checks and taking advantage of built-in error reporting tools.

[Grob needs help]

ok i have used that code and it come out with

A fatal MySQL error occured.
Query: UPDATE flight SET attacked = 'testuser1' AND attacking = 'testuser2' WHERE name = 'testuser1'
Error: (1065) Query was empty

how do i stop this from happening?

[Grob needs help]

oh hang on i see why:
you put

PHP Code:

$result = mysql_query($query) 


but it should have been

PHP Code:

$result = mysql_query($sql) 


that is most likely why the error was occuring

but now it is not showing any error message but still not doing anything to the database

[ehymel]

oops, my by bad! This error is in both places. Sorry about that!